search

goatcorp / Plogon

Build system for Dalamud Plugins
7 stars 13 forks source link

Add --static-folder #2

Closed NotNite closed 2 years ago

NotNite commented 2 years ago

Makes running Plogon on non-hircine development environments possible. Also fixes a hardcoded Windows-only named pipe and made the entrypoint script executable (lmao).

philpax commented 2 years ago

lgtm, but I think we should set up CI before we merge this, just to have that beautiful green tick. Do you mind setting that up in another PR?

goaaats commented 2 years ago

Think having docker images on ghcr would be good, you can probably just copy in a .NET dockerfile + actions set up, there should be one in the operator repo

NotNite commented 2 years ago

I don't think CI would work without this PR? The Windows pipe is still hardcoded, and the file path is still hardcoded to goat's machine.

philpax commented 2 years ago

Good point, could maybe be a little naughty and just get CI working in this PR?

NotNite commented 2 years ago

Not sure if I'm entirely ready to tackle that yet (not too sure what I need to do tbqh). Also I'm a docker noob so the git history will be VERY messy - not a good idea.

philpax commented 2 years ago

That shouldn't be too bad - it'll be a combination of https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action and https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net.

The Git history is fine, we can always clean it up afterwards (rebase interactive isn't too bad once you get used to it.) Give it a shot!

NotNite commented 2 years ago

I've got some basic CI to build Plogon set up - nothing fancy. Is this good?

philpax commented 2 years ago

lgtm, @goaaats can merge once he's happy