search

goatcorp / Plogon

Build system for Dalamud Plugins
7 stars 13 forks source link

Accept Git URLs that don't end in .git #30

Open philpax opened 2 years ago

philpax commented 2 years ago

The DIP17 spec allows for anything that can be git cloned; GitHub will serve up the repo to a Git client even if you don't end in .git. I think we can remove the check and it should Just Work:tm:

wolfcomp commented 1 year ago

Be warned that this would also need to modify the code added with #26 as it expects the URL to have .git currently with [..^4] on the AbsolutePath of the URL that is sent.

Note: Internally in C# this is called URI as it can be anything that follows <method>://<path>