search

goatcorp / Plogon

Build system for Dalamud Plugins
7 stars 13 forks source link

Submodules are not recursively cloned #51

Closed philpax closed 5 months ago

philpax commented 9 months ago

In this PR. the OtterGui submodule is fetched, but the OtterGuiInternal submodule isn't.

This looks like the relevant code in Plogon:

https://github.com/goatcorp/Plogon/blob/3e3768659284440d52d4b86c751e07467707f024/Plogon/BuildProcessor.cs#L763-L784

but I'm not sure how to fix this. Do we need to fetch/checkout for each submodule within the submodule loop? Or do we specify a recursive pull within the Clone? SubmoduleUpdateOptions does not have an option for a recursive update.