Hack to fix runtime deps erroring

goatcorp / Plogon

Build system for Dalamud Plugins

7 stars 13 forks source link

Closed NotNite closed 5 months ago

NotNite commented 8 months ago

Added runtimes we were having issues with to the RUNTIME_PACKAGES constant (OBSPlugin and SonarPlugin)
Made runtime deps a warning instead of fatal because some of them just don't exist I guess. Not too happy about this so I'd like some input
Removed the assumption that [..6] was safe and instead splits the string - I tested this on both plugins with issues and it seems to work okay? Hope that's enough
This does not update the extended image because I have no idea how to do that

karashiiro commented 5 months ago

Would be really cool to get this merged, I just spent 3 hours working around mostly this issue https://github.com/goatcorp/DalamudPluginsD17/pull/3348

philpax commented 5 months ago

@goaaats any reason not to merge this?