Fix missing platform specific runtimes and incorrect runtime versions

goatcorp / Plogon

Build system for Dalamud Plugins

7 stars 13 forks source link

Fix missing platform specific runtimes and incorrect runtime versions #9

Closed Styr1x closed 2 years ago

wolfcomp commented 2 years ago

seeing how all of them use the same

new NugetLockfile.Dependency()
{
    Resolved = RUNTIME_VERSION
}

couldnt it be an idea to make that static? something in the line of

private static NugetLockfile.Dependency RuntimeDependency = new NugetLockfile.Dependency()
{
    Resolved = "6.0.5"
}

...
await GetDependency("Microsoft.AspNetCore.App.Ref", RuntimeDependency, pkgFolder, client);

Styr1x commented 2 years ago

I did refactor that part and on top made the package fetching parallel, this is now much faster than before.