search

goatcorp / XIVLauncher.Core

Cross-platform version of XIVLauncher, optimized for Steam Deck
GNU General Public License v3.0
84 stars 35 forks source link

Remove dx9 #124

Closed Blooym closed 1 month ago

Blooym commented 2 months ago

Removes all dx9 components from XLCore

There are still some parts of XLCommon that need removing and will need updating in this PR.

rankynbass commented 2 months ago

This doesn't build against the current FFXIVQuickLauncher master. I think you didn't update the submodule before testing. Currently getting this error:

/tmp/xlcore-src/src/XIVLauncher.Core/Components/MainPage/MainPage.cs(171,26): error CS1501: No overload for method 'LaunchGame' takes 11 arguments [/tmp/xlcore-src/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/tmp/xlcore-src/src/XIVLauncher.Core/Components/MainPage/MainPage.cs(825,44): error CS1501: No overload for method 'LaunchGame' takes 11 arguments [/tmp/xlcore-src/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
goaaats commented 2 months ago

She made this before I made my changes that remove DX9, you should just need to remove the argument - was the only thing that needed changing.

Blooym commented 2 months ago

Should build again now

rankynbass commented 2 months ago

Awesome. Was just trying to update the compatibility rework patches to work with latest, and the remove dx9 bit was causing issues.