search

goatcorp / XIVLauncher.Core

Cross-platform version of XIVLauncher, optimized for Steam Deck
GNU General Public License v3.0
84 stars 35 forks source link

Fix warnings #126

Closed NotNite closed 1 month ago

NotNite commented 1 month ago

Some are just blatant null! and !, some are disabling warnings in places they don't make sense (Veldrid device creation), some are actual null checks.

image

Blooym commented 1 month ago

Going to daily drive this locally for a few days to ensure that everything works as expected.

Everything seems fine right now though, so I don't expect any changes being needed.

rankynbass commented 1 month ago

I'm having problems building this in a flatpak. Getting a bunch these errors:

/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(143,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(145,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(168,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(170,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(178,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(180,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(181,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(182,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(183,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
NotNite commented 1 month ago

Ah, must be because required doesn't work in NET 6. One moment...

rankynbass commented 1 month ago

Builds in flatpak now.

philpax commented 1 month ago

This seems reasonable. Happy to merge if @Blooym hasn't encountered any issues.