goatfungus / NMSSaveEditor

No Man's Sky - Save Editor
1.93k stars 244 forks source link

Issues in latest experimental patch #111

Closed TheBob12 closed 6 years ago

TheBob12 commented 6 years ago

After saving ingame in the experimental version of NMS on steam, I can no longer open the save files in the save editor, but works fine to load ingame.

I get this error: https://imgur.com/3x18aMc

The log file:

[INFO] Mem Usage: 129/1891 MB [INFO] Latest version: "1.5.21" [INFO] Current version: "1.5.21" [INFO] Loading slots: C:\Users\Hallu\AppData\Roaming\HelloGames\NMS\st_76561198157096356 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Loading saves for Slot 1... [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] No current save file found for Slot 1 - [EMPTY] [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0 [INFO] Version unknown: 0

TheBob12 commented 6 years ago

Update:

it appears they have obfuscated the savegame files... https://i.imgur.com/nBtW2IJ.png

gmwjs22 commented 6 years ago

saving game the experimental , no longer works. I have the same problem

TheBob12 commented 6 years ago

@gmwjs22 Yes that error occurs because the saveeditor is trying to read a specific index from the savegame files that no longer exist, because they have been obfuscated. Which explains why "[INFO] Version unknown: 0" is spammed in the console

In the new savegame file for me what is supposed to look like: "Version": 4626, "Platform": "Win|Final",

Now looks like: "8>q": "Win|Final", "F2P": 4626,

pixelbart commented 6 years ago

Yeah they changed all the keys.

goatfungus commented 6 years ago

Oh crap.... this might be a problem going forward...

EDIT: I'm putting everything else on hold while I find a solution to this.

Alterios commented 6 years ago

I have the same values as @TheBob12. It looks to my untrained eye like all they did was replace the names of the variables. it might be just a matter of replacing the old names with the new ones. and temporarily running a new fork for the experimental branch

goatfungus commented 6 years ago

Yeah, all they did was replace all the names in the save file with 3 character replacements.

I think the best step here is to create a dictionary file and use a detection process as part of the version check to determine whether the dictionary should be used or not. This would have the added advantage of not requiring a new fork for experimental.

I have almost finished the dictionary, and I'm just testing it on the save file before I implement it fully in the editor. Should hopefully have a new version in the next few hours.

goatfungus commented 6 years ago

I have pushed up an experimental build here: https://github.com/goatfungus/NMSSaveEditor/raw/experimental/NMSSaveEditor.zip

This should correctly map all the changed names in the save file to what they were previously (so the JSON editor is still useful), and reverts it back again once you save.

NOTE: This is an experimental build and should be used with caution. Please backup your NMS save folder before use.

meachware commented 6 years ago

First Thank you! I'm on the EXP release and the update was able to read in my save file. I manually edited the RAW JSON (frackin' rebound boltcaster). Opened in NMS fine and all looks ok. I then max filled a couple of items and that worked fine too.

However I am getting maybe 40-ish "name mapping not found: XXX" errors. One is for "RV1". While I can't copy them from the CMD.exe window I can certainly list them here if it helps.

goatfungus commented 6 years ago

Those are only warnings really.... the editor should still handle them fine. If you could post your log file that would help.

TheBob12 commented 6 years ago

I'm still having the same issue even with your experimental release... are we sure that the indices aren't encrypted in the same way as they were before? https://github.com/matthew-humphrey/nmssavetool

meachware commented 6 years ago

I don't know where/which logs - let me know and I'll post them :)

TheBob12 commented 6 years ago

@meachware it's called NMSSaveEditor.log and should be located in the same directory as the NMSSaveEditor.jar file... I have mine on my desktop and that's where it saves the log file. Also: it appears to save the log file on closing the application.

meachware commented 6 years ago

@TheBob12 - THANKS! NMSSaveEditor.log

Alterios commented 6 years ago

I went through my save files from pre-update and my new one and found the following values for the missing names. [INFO] name mapping not found: M2L - Could not find in my save file [INFO] name mapping not found: RVl - "Palette" [INFO] name mapping not found: Ty= - "ColourAlt" [INFO] name mapping not found: xEg - "Colour" [INFO] name mapping not found: @6c - "TextureOptionGroupName" [INFO] name mapping not found: =Cv - "TextureOptionName" [INFO] name mapping not found: tIm - "BoneName" [INFO] name mapping not found: kpg - the value under "RepairTechBuffer", it does not show up in any of the backup saves I have pre-update.

Xavanil commented 6 years ago

Here's another log using the Experimental version with the mapping messages - hope it helps. NMSSaveEditor.log

goatfungus commented 6 years ago

Thanks @Alterios for the mapping info, I'll add it to the dictionary file in the editor.

I am still trying to find the actual mapping algorithm they use internally in NMS. This would be a much better solution than having a hard-coded mapping file, but I still haven't found it yet.

Goose7 commented 6 years ago

First of all I wanted to say THANK YOU! Thank you for creating and continually improving this excellent and highly useful NMS companion tool! I don't know what I would do if I didn't have this thing at my disposal! Seems I find one reason or another to use it pretty much every single day!

While I am new here, I have been using your editor since the very first week you originally released it all those many, many months ago.

So glad you are already on the case with trying to get everthing working again with the EXP! I was really worried that the future of the trusty NMSSFE was in real danger. And I really felt for you when this happened considering the TON of work you have been putting into the project since NEXT launched last month.

Goose7 commented 6 years ago

I just got done testing out your recently posted Experimental version of the editor on my 850 Hour Legacy Save file and everything appears to be working fine.

I am getting all those same error messages displayed in the console that other users have already reported, but the editor itself seems to be doing everything it is supposed to be doing, and I just loaded up the save file it edited into the NMS Exp build without any issues that I have seen so far.

In terms of what I did while in the editor...

I refilled some of my Frigate Fuel stacks, expanded the slot size of my exosuit cargo section, and finally swapped in a different SEED value for one of my Exotic Ships.

And again... Aside from a whole bunch of various error messages being posted to the console display, everything I changed and saved was present in the game, and there were no issues with using any of them.

Impressive for the first version of this quickly assembled update! 👍

goatfungus commented 6 years ago

Normally I wouldn't need to have a separate experimental build for the editor, but because of the total remapping of every key in the file this is a really special case. I generally prefer to keep one editor build compatible with all minor versions of the game, and I plan to go back to that when (or if) these experimental changes actually get pushed onto the public build.

It kinda sucks that once you "upgrade" a save to the experimental build there is no way to play it again if you revert back to the standard public build. I'm working on some tweaks to this experimental build to allow saving back in the older format.

Goose7 commented 6 years ago

i hear ya about the one way file conversion. That would be cool to have the option to save back to the previous format. I know a lot of people got burned by this update because HG failed to inform anyone that the save files were going to get converted to a new format incompatible with all previous versions.

A change like this only happened one time before towards the end of Atlas Rises and they made a pretty big deal about it before and after that particular Exp was released. Everyone running on the EXP branch knew going in what to expect. I am sure you remember the one I am talking about. That was the update where they changed the inventory management/transfer system to what the game uses now.

I have put several hours into the game after updating and saving with your current Exp version. No issues that I have seen.

Great work! Looking forward to trying out the next update. Will it get pushed automatically, or will we need to come up here to get the new version?

goatfungus commented 6 years ago

Ok, since this patched version seems to work fine on both public and experimental releases of NMS, I have merged the changes in the editor into my master branch. If you have downloaded the experimental version it should auto-update to the new version.

I guess we'll see what HG decides to do with this mapping going forward....

Zeoran commented 6 years ago

I also wanted to once again, say THANK YOU, for all your hard & amazing work. You not only have an editor, but one that is very robust, extremely easy to use and one I would easily pay for, if I had any income.

I'm still not sure how my earlier inquiries got me flagged here on github, but at least the editor works!

Goose7 commented 6 years ago

Great! Thanks for the quick work! I just ran the earlier version of the editor to change one of my Exotic Ship Seeds and the auto-update feature worked like a charm!

I just came up here to confirm that the two versions had indeed been merged since I didn't see "Experimental" listed after the file name like it had with the original version.

Ran some quick tests and everything worked fine, aside from the fact that I am still getting a string of error messages on the console when I first select my save slot of choice.

goatfungus commented 6 years ago

Can you share the error messages? Most of these should have been resolved with the new version.

Goose7 commented 6 years ago

Sure! I need to quit out of the game and run the editor again. Will all those messages be in the log file? I don’t need to screenshot the console or anything right?

Stand by! I will just email it to you in another reply shortly.


Goldengoose7 goldengoose7@gmail.com

On Aug 25, 2018, at 11:08 PM, Brendon Matthews (GoatFungus) notifications@github.com wrote:

Can you share the error messages? Most of these should have been resolved with the new version.

goatfungus commented 6 years ago

Sent it where?

Goose7 commented 6 years ago

I sent the log and a screenshot of the console as a reply to your email. Did you not get them? I sent 2.


Goldengoose7 goldengoose7@gmail.com

On Aug 25, 2018, at 11:48 PM, Brendon Matthews (GoatFungus) notifications@github.com wrote:

Sent it where?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/goatfungus/NMSSaveEditor/issues/111#issuecomment-416017979, or mute the thread https://github.com/notifications/unsubscribe-auth/AI5kPYRLvoSkYVkxV62imWoIyUntcXV_ks5uUkS-gaJpZM4WLghp.

goatfungus commented 6 years ago

I think github strips attachments if you send them by mail.... you would need to D&D them into the github message box.... sorry.

Goose7 commented 6 years ago

Oh! Right! I see how this is working. I got your request as an email. Assumed it was separate from this section here. You were right... Doesn't look like the file attachments I sent were included in my earlier emailed replies.

Attempting to include them below using the web page instead:

NMSSaveEditor.log

screenshot_20180825233728

Goose7 commented 6 years ago

Forgot to mention... Those errors above are not the exact same ones I was seeing with the previous EXP version of the Editor.

I believe that q5u mention was included then too, but there were others that are no longer being displayed/reported. So it looks like some progress was made between versions. 👍

goatfungus commented 6 years ago

Cool, thanks for that. I have found the appropriate mapping for "q5u" in one of my other pre-NEXT saves, but the other 2 I'm not sure of yet.

"kpg" is a key that's been added in experimental, so I don't think we'll find the mapping by comparing saves.

You might be able to find the replacement for "M2L" (I don't have it in any of my saves). Load the JSON editor on your save and do a search for "M2L", and when you find it you should be able to figure out where it is in a backup by looking at the keys near it.

goatfungus commented 6 years ago

Added to the editor (not released yet) are the following mappings: q5u=CN kpg=MultiplayerPrivileges

If anyone sees any other "mapping not found" messages showing up, please list them here.

meachware commented 6 years ago

A few from this am on a fresh character in 1.57 exp NMSSaveEditor.log

goatfungus commented 6 years ago

@meachware Thanks for that.... how far exactly have you got through the game? I just tried a new character on normal and can't get "M2L", ";YC", or "WX8" to come up.

meachware commented 6 years ago

I was 1/2 through repairing my starter ship

meachware commented 6 years ago

ah, my starter ship was replaced with the bonus content ship - sorry :(

meachware commented 6 years ago

There is something wrong with slots in both the Exosuit; general and cargo and the ship. I expanded my ship to 31 slots (6x6 w/5 missing) but it in game it lists my ship as 31 slots but only shows 29 available. Yesterday my exosuit slots were off by a row (I think 3 slots) until I purchased upgrades to match. However, I could actually use the slots (send to and transfer) just not seeing them in the game UI. In my new character I added one cargo to my exosuit and it's location is wrong, it's at column 5 row 1 instead of in the 1,1 position.

Rianon commented 6 years ago

It's a known bug in exp build right now.

meachware commented 6 years ago

@Rianon - thanks :)

Goose7 commented 6 years ago

@goatfungus --How do I search for a specific thing in the Raw Json editor? (M2L)

I don't see any search box or anything. I located the "TeleportEndpoints" section I edited the other day totally by accident. lol!

@Rianon The slots for my suit's fully upgraded cargo section on my legacy save looked odd too when I first looked at it using the new editor. In the actual game, I had a blanked out row below the activated slots. It looked nothing like the image below from the editor. Nothing blanked out on the right side. Just a blanked out single row at the bottom.

screenshot_20180825171251

How many slots is the cargo section supposed to max out at? Been so long since I upgraded it I forgot.

Rianon commented 6 years ago

48 cargo in NEXT.

Goose7 commented 6 years ago

So it is the same Max as the General Suit Inventory section then? For some reason I was remembering 42 slots max for cargo.

As you can see from the above image, the Exp reset my Cargo section to 30 slots. Guess I need to go in and in the missing slots to my Cargo section.

Rianon commented 6 years ago

As you can see from the above image, the Exp reset my Cargo section to 30 slots. Guess I need to go in and in the missing slots to my Cargo section.

I don't think it's a save file bug... if you planning to fix it with editor.

Goose7 commented 6 years ago

I just fixed it with the editor, so I have my original 48 slots back! -- I am sure the reduction to 30 was the result of those same issues with the original version of this EXP which changed the General section to 42, but was then patched by HG with a second Exp release.

Rianon commented 6 years ago

I just fixed it with the editor, so I have my original 48 slots back! -- I am sure the reduction to 30 was the result of those same issues with the original version of this EXP which changed the General section to 42, but was then patched by HG with a second Exp release.

And you can see and use all slots ingame? Interesting.

goatfungus commented 6 years ago

@Goose7 to use the search function in the JSON editor:

Ctrl-F = brings up the find dialog Ctrl-G = find next

Goose7 commented 6 years ago

@goatfungus -- AH HAH! I knew I was missing something.

Okay... I will have a look through my save file after lunch and report back.

Thanks for the info.

Goose7 commented 6 years ago

@goatfungus -- M2L is found right under something called "UsedEntitlements" (in the Right Hand Column)

Here is the full string that includes M2L

"M2L":"HORIZOSHIP000000"

That appears to be the only occurrence of those three characters.

Is this what you were looking for?

Goose7 commented 6 years ago

Also... Is there a keybind for Copy/Paste in the Raw Editor? I wanted to just grab that whole section and paste it into a message here, but I couldn't figure out how to do it. So I just transcribed the code above manually.