goatfungus / NMSSaveEditor

No Man's Sky - Save Editor
1.63k stars 228 forks source link

[Request] Please add UI support Inventory_Cargo and FreighterInventory_Cargo (maybe *_Cargo) #831

Open SplinterGU opened 1 year ago

SplinterGU commented 1 year ago

please, add ui support to:

PlayerStateData.Inventory_Cargo PlayerStateData.FreitherInventory_Cargo ShipOwnership.*.Inventory_Cargo

(maybe other *_Cargo)

this inventary are used as extra cargo... in the game this is access only with "quick transfer", but is very annoying...

image image image

MGJerry commented 1 year ago

Wait, hol' up. How are you even accessing those inventories? I thought those were deprecated a few updates ago? Those items should have gone into your now combined inventory the moment you open the inventory ingame.

Edit: Just opened an old backup in the latest version of the editor, those Cargo inv are still accessible if the editor see an older game version (from when those Cargo inv are still in use) image

SplinterGU commented 1 year ago

Wait, hol' up. How are you even accessing those inventories? I thought those were deprecated a few updates ago? Those items should have gone into your now combined inventory the moment you open the inventory ingame.

Edit: Just opened an old backup in the latest version of the editor, those Cargo inv are still accessible if the editor see an older game version (from when those Cargo inv are still in use) image

cargo is normal inventory in my editor

image

SplinterGU commented 1 year ago

you can see that in Cargo 0,0 I have Platinum... in the json I have WATER2...

MGJerry commented 1 year ago

Ah, that... Yeah, since NMS 4.0, General and Cargo inventories got merged, and all data is stored in the Inventory names (no "_Cargo") and those "_Cargo" inventories are now deprecated ingame. @goatfungus probably choose "Cargo" 'cause the new stack limits are similar to the ones of "Cargo"s, but I still feel they should be named "General"s to avoid confusions.

Side notes, about the data in Cargo inventories - yeah... some of them still have data leftover in some of my save files, they don't do anything (except if you count increasing the size of the save then yes, they do, by like a bit)

SplinterGU commented 1 year ago

Ah, that... Yeah, since NMS 4.0, General and Cargo inventories got merged, and all data is stored in the Inventory names (no "_Cargo") and those "_Cargo" inventories are now deprecated ingame. @goatfungus probably choose "Cargo" 'cause the new stack limits are similar to the ones of "Cargo"s, but I still feel they should be named "General"s to avoid confusions.

Side notes, about the data in Cargo inventories - yeah... some of them still have data leftover in some of my save files, they don't do anything (except if you count increasing the size of the save then yes, they do, by like a bit)

no, no... this inventary is functional... I remove all items from it... then when main inventary is full, the new items will go to the inventary_cargo... this inventary works... don't is obsolete...

SplinterGU commented 1 year ago

look the images... yellow are normal inventory... red is inventory_cargo... it is functional... this is a new ship from some days ago... maybe v4.25... this isn't obsolete...

275850_20230606132452_1 275850_20230606132348_1 275850_20230606132310_1 275850_20230606132235_1 275850_20230606132201_1

MGJerry commented 1 year ago

Ok, I kind of get the gist of it now. After testing with 3 of my vanilla saves (1 in Normal difficulty, 1 in Survival difficulty and 1 in Expedition 7), none of them ever overflow items to the unused Cargo space, and instead overflow to the ships or freighter (if the player can access them). So, the fact that those items go there mean this is a strictly "modded" problem. Don't know if goat gonna support modded stuff like this, so I'm gonna leave it to him to respond to this.

If you really need to modify those Cargo inventories, the best I can offer is to used the 1.13.8 version of the editor (when those haven't been taken out yet) Here's the link to it: https://github.com/goatfungus/NMSSaveEditor/blob/1cffdf4759bed90f00480f51f7d041000a8d956c/NMSSaveEditor.zip

image The "==Unused==" tab is what you need for those inventories ending in "_Cargo"

Edit: It works with a save of mine that still have stuff in there, so I wish you the best of luck

SplinterGU commented 1 year ago

you can get an exosuit overflow if you get items from anomaly (transfers from other users) or if you use duplication glitch or something other method (I don't remember now), in the ship if you craft item from asteroids in the space... I can try use an old nmssaveedit, but what about all bugs or missing features of this old version? I think that isn't a solution... All my previous tickets of bug reports or suggest was logic and correct... I don't understand what is the problem with this... the issue exists, is a reality... and need a fix... if HG don't give us a fix for it, I think that will be great that NMSSaveEdit can handle this issue...

MGJerry commented 1 year ago

you can get an exosuit overflow if you get items from anomaly (transfers from other users) or if you use duplication glitch or something other method (I don't remember now), in the ship if you craft item from asteroids in the space...

I got a friend up to test this and yep, it does overflow when somebody gives you an item when inventories a full, so I do apologize on that part. Ngl, that's a massive oversight they should have fixed (although I can't find much posts about it, nor too much mentions about it in the discord server)

but what about all bugs or missing features of this old version? I think that isn't a solution...

Just edit what you need in the v1.13.8 editor, copy what's in the raw json and paste it to the newest editor, that's literally my best suggestion for you right now. And for the re-adding of the "_Cargo" tabs, we will have to wait for Brendon's response (or you know, until HelloGames actually fix their mistake)

SplinterGU commented 1 year ago

No problem...:) About edit json raw, isn't easy... each slot have coords... Isn't easy... I did several tools for mánage nms json raw data, but isn't the idea... I don't want do double work... I don't want do a new editor... This editor Is great... Anyway, thanks!

El mié., 7 jun. 2023 10:28 p. m., MG Jerry @.***> escribió:

you can get an exosuit overflow if you get items from anomaly (transfers from other users) or if you use duplication glitch or something other method (I don't remember now), in the ship if you craft item from asteroids in the space...

I got a friend up to test this and yep, it does overflow when somebody gives you an item when inventories a full, so I do apologize on that part. Ngl, that's a massive oversight they should have fixed (although I can't find much posts about it, nor too much mentions about it in the discord server)

but what about all bugs or missing features of this old version? I think that isn't a solution...

Just edit what you need in the v1.13.8 editor, copy what's in the raw json and paste it to the newest editor, that's literally my best suggestion for you right now. And for the re-adding of the "_Cargo" tabs, we will have to wait for Brendon's response (or you know, until HelloGames actually fix their mistake)

— Reply to this email directly, view it on GitHub https://github.com/goatfungus/NMSSaveEditor/issues/831#issuecomment-1581753571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW2IAYSMEX3NU3J2EEAP723XKETFVANCNFSM6AAAAAAY2HSRHM . You are receiving this because you authored the thread.Message ID: @.***>