search

goatfungus / NMSSaveEditor

No Man's Sky - Save Editor
1.63k stars 228 forks source link

Publish source code #911

Closed mfoulks3200 closed 4 months ago

mfoulks3200 commented 7 months ago

Hello! I came across your project when wanting to translate my switch save to my new Steamdeck. It's a great project, and looks really well put together, but I noticed you haven't included any source code in the repository— just the compiled binaries. If you were to share the source code of the project in the repo, then others (such as myself) would be able to contribute code and features to the project as well.

cjg67 commented 4 months ago

To contribute you would need to know how to program in java, as this is what this app is based on. From reading the description, this editor was originally developed for the Author's personal use, and they later decided to put it up for everyone to use. I also doubt that this far along that the source code will be released. It is one way to ensure that the structure of the app is always kept the same way for when the main Author decides to add things, so that they do not have to spend extra time going through sections that they have not added.

mfoulks3200 commented 4 months ago

I am aware of the requirements for this project. I'm a developer for a major software company, working in Typescript and Java professionally.

As for access to the source code— GitHub is intended to be a file hosting platform, the entire point of creating a project here is to share your code, and allow others to contribute. To that end, there are a lot of tools built in to facilitate some of the issues you mentioned, like pull requests, which can ensure that no code makes it into the codebase that the owner hasn't explicitly reviewed.

cjg67 commented 4 months ago

I am well aware of all the tools built into github as I have used a number of them.
There is no requirement for any person posting to github to actually provide source code. I appreciate that you are another IT professional, but you are also failing to understand that for some people who post here, any extra amount of time that they need to take to review anything that others provide, takes away from what they want to do with their app. Also, take a look at the current pull requests, and you will see that a number of them are very old, as the owner has not actually authorized any of them.