search

goatfungus / NMSSaveEditor

No Man's Sky - Save Editor
1.62k stars 227 forks source link

Deleting ship in editor changes other customized ship #976

Open still18 opened 3 months ago

still18 commented 3 months ago

Weird bug I found (Steam/Mac/command line jar) with the new Orbitals update. I built an explorer in the custom builder added to NMS in the orbital update. However, when I go into the save editor and delete a ship, upon reloading the game the ship has completely changed parts and color. I also tested this by deleting the same ship in game via the scrapping mechanic and this issue does NOT happen like it does in the save editor. The first image is the customized ship, and the second is the ship after this bug happens. It is worth noting that the ship I deleting is first in my list, and the customized ship is last in my list. This is obviously not a super pressing issue but just wanted to document it; thanks for your work on this editor. 20240401225003_1 20240401224822_1

AndrewSunshiny commented 3 weeks ago

Encountered the same issue, it seems that ship data (ShipOwnership) and ship customization data are stored separately from each other. Probably ship customization data has a reference to the ship by ID, and the problem is it's not being updated when the ship's order changed externally.