goatshriek / stumpless

a C logging library built for performance and features
https://goatshriek.github.io/stumpless
Apache License 2.0
446 stars 335 forks source link

improve network targets #404

Closed goatshriek closed 8 months ago

goatshriek commented 8 months ago

Makes improvements focused on network targets, including:

WSAStartup and WSACleanup are now only called the first time needed and upon stumpless_free_all, respectively, instead of once for each network target opened/closed.

TCP network targets using the sys/socket.h implementation will detect a FIN message before a send and fail immediately. Before this change, the closure of the stream was not caught noticed and message sends would return with a success code despite not having being received by the remote end. TCP network targets using the Winsock implementation still exhibit the later (broken) behavior.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (latest@8f3d535). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## latest #404 +/- ## ========================================= Coverage ? 90.54% ========================================= Files ? 46 Lines ? 4188 Branches ? 556 ========================================= Hits ? 3792 Misses ? 273 Partials ? 123 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud