search

goatshriek / stumpless

a C logging library built for performance and features
https://goatshriek.github.io/stumpless
Apache License 2.0
446 stars 335 forks source link

added prival to string function #413

Closed uFarad closed 6 months ago

uFarad commented 6 months ago

Added function to convert the prival integer to a string in response to issue #245

@mk722 did great work on this previously, but seems to be inactive now after a bout with COVID. I hope they had a speedy recovery.

I took over this change from where they left off. Please let me know if anything needs to be changed or if I am not following proper procedures. I hope to contribute to more open source projects like this one in the future.

goatshriek commented 6 months ago

Note that the continuous integration tests cannot run until the merge conflicts are resolved.

uFarad commented 6 months ago

It successfully compiles and passes tests locally. It should be good to go.

goatshriek commented 6 months ago

Thanks very much for getting this together! You can disregard the codecov upload failures, those are due to a separate issue I am working on addressing. I will do a more thorough review of the change in the next few days.

goatshriek commented 6 months ago

Thank you once again for working through this! My apologies for the many confusing CI failures - you had the misfortune of committing during a time of codecov breakage and also discovering a bug in the header checking tool.

uFarad commented 6 months ago

It was my pleasure. Thank you for creating an amazing project that is friendly to those new to OSS.