search

goatslacker / alt

Isomorphic flux implementation
http://alt.js.org/
3.45k stars 323 forks source link

DOCS: Constant UPDATE_LOCATIONS not defined in previous actions section #568

Closed thinkloop closed 8 years ago

thinkloop commented 8 years ago

In the store docs: http://alt.js.org/guide/store/

There is handleUpdateLocations: LocationActions.UPDATE_LOCATIONS

However in the previous actions sections: http://alt.js.org/guide/actions/

There is no mention of the constant UPDATE_LOCATIONS.

yujingz commented 8 years ago

@thinkloop updateLocations was defined in the LocationActions and it automatically gets you the action symbol UPDATE_LOCATIONS. This is because behind the scenes flux uses these constants to dispatch events.

thinkloop commented 8 years ago

Thanks for the reply. So does it use the camel case to decide where to put the underscore? On Dec 15, 2015 3:20 PM, "Yujing Zheng" notifications@github.com wrote:

@thinkloop https://github.com/thinkloop updateLocations was defined in the LocationActions and it automatically gets you the action symbol http://alt.js.org/docs/actions/#actionconstant UPDATE_LOCATIONS. This is because behind the scenes flux uses these constants to dispatch events.

— Reply to this email directly or view it on GitHub https://github.com/goatslacker/alt/issues/568#issuecomment-164885404.

yujingz commented 8 years ago

yeah that's the convention

thinkloop commented 8 years ago

Thank you. I am replying by email but will close the issue when I get back to my desk. Please feel free to close meanwhile.

Best, Baz On Dec 15, 2015 5:54 PM, "Yujing Zheng" notifications@github.com wrote:

yeah that's the convention

— Reply to this email directly or view it on GitHub https://github.com/goatslacker/alt/issues/568#issuecomment-164916466.