search

goatslacker / alt

Isomorphic flux implementation
http://alt.js.org/
3.45k stars 323 forks source link

Fix failing Promises example from the documentation. #606

Closed mareksuscak closed 8 years ago

mareksuscak commented 8 years ago

This PR fixes #584.

mareksuscak commented 8 years ago

@goatslacker Can you also consider merging this PR?

goatslacker commented 8 years ago

Yup I'll take a look

goatslacker commented 8 years ago

@mareksuscak can you link to the example in the documentation.

Also, should we still dispatch on success?

mareksuscak commented 8 years ago

@goatslacker Sure, here it is: http://alt.js.org/docs/createActions/#dispatching - example at the bottom. Not sure what you mean by dispatching on success. This PR modifies the async action invocation code which will return an enclosing (inner) function's return value.

goatslacker commented 8 years ago

Ah I get it now. Thanks :D

goatslacker commented 8 years ago

Will publish this.

mareksuscak commented 8 years ago

Awesome. Thanks. Looking forward to new release.

goatslacker commented 8 years ago

Published as 0.18.2. Thanks again!