In spirit of #hacktoberfest, here are all of my changes

goatslacker / get-parameter-names

Retrieves the argument names of a function

46 stars 13 forks source link

In spirit of #hacktoberfest, here are all of my changes #17

Open CaptEmulation opened 6 years ago

CaptEmulation commented 6 years ago

Support for ES6 class constructors
Support for default arguments
Fixes a variety of edge cases

However... because we are now doing more parsing...

bigger
slower

Not having to worry about how functions are written...

priceless

Updated from #16 to revert package name.

CaptEmulation commented 6 years ago

Yeah so I guess the tests can only be made to run on newer nodes (w/ support for class) so that would mean node >= 4.x but Travis only covers 0.6 => 0.12 :-(

Vincz commented 6 years ago

Great contribution @CaptEmulation What do you thing about #18 ? Do you think it would be hard to implement ?

CaptEmulation commented 6 years ago

@Vincz Unfortunately no I am not currently supporting destructured arguments with my change. I briefly investigating using a full code parser but found the runtime performance and the package size to be undesirable. The approach here is more low level and does not have a full featured JS parser.