goauthentik / authentik

The authentication glue you need.
https://goauthentik.io
Other
13.67k stars 916 forks source link

authentik tells the user what's wrong when creating an application with the wizard #11977

Closed 4d62 closed 1 day ago

4d62 commented 1 week ago

Is your feature request related to a problem? Please describe. Yes, when I attempt to add authentik to an application I run or use, I'm frustrated when one of my inputted values are incorrect and I have to guess which one is wrong.

Describe the solution you'd like authentik should tell the user what's wrong when an application/provider is created with the wizard -> once the user clicks submit -> or authentik should stop the user from clicking submit until errors are fixed

Describe alternatives you've considered Looking in the console, finding the response with code 400, and expanding the json to find what's wrong

Additional context The error authentik returns TktspI

What the server returns zlh5Ps

kensternberg-authentik commented 1 week ago

There is a (fairly large) PR that includes a fix for this. If you would like to review it and make comments, we would greatly appreciate it.

https://github.com/goauthentik/authentik/pull/11856/files#diff-212d8e0f0aa3c9276c277771b11e722062a0ce78013696122ad1bfe310e2a126R155

4d62 commented 1 week ago

thanks!

kensternberg-authentik commented 1 week ago

Also, I realized that the error reporting is unrelated to the issues covered in the big PRs (like Form Unification and providing Policy Binding access in the wizard), so I've created a PR just for this issue: Web: fix bug that prevented error reporting in current wizard.

(But I would dearly love any feedback on the new forms & policy bindings stuff!)

4d62 commented 1 week ago

i'll take a look when i have a second! i've done about 2 hours of frontend in my entire life so please do take what I say with a grain of salt 🤣

4d62 commented 1 day ago

closing as resolved by #12033