goauthentik / authentik

The authentication glue you need.
https://goauthentik.io
Other
13.72k stars 918 forks source link

web: applications: redirect user on application rename #11981

Open 4d62 opened 2 weeks ago

4d62 commented 2 weeks ago

closes #11973

Details

REPLACE ME


Checklist

If an API change has been made

If changes to the frontend have been made

If applicable

netlify[bot] commented 2 weeks ago

Deploy Preview for authentik-docs ready!

Name Link
Latest commit 6837d8ec39553dcbf864fa2bc5c1fd5bc061643d
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/673e447b38beae0008670ff2
Deploy Preview https://deploy-preview-11981--authentik-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for authentik-storybook ready!

Name Link
Latest commit 6837d8ec39553dcbf864fa2bc5c1fd5bc061643d
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/673e447b94f3a80008218ba9
Deploy Preview https://deploy-preview-11981--authentik-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.56%. Comparing base (b2c9dff) to head (0c1ba8c).

Files with missing lines Patch % Lines
authentik/core/api/applications.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11981 +/- ## ========================================== - Coverage 92.58% 92.56% -0.02% ========================================== Files 761 761 Lines 37822 37829 +7 ========================================== + Hits 35016 35018 +2 - Misses 2806 2811 +5 ``` | [Flag](https://app.codecov.io/gh/goauthentik/authentik/pull/11981/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goauthentik) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/goauthentik/authentik/pull/11981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goauthentik) | `49.19% <14.28%> (-0.02%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/goauthentik/authentik/pull/11981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goauthentik) | `24.91% <14.28%> (-0.01%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/goauthentik/authentik/pull/11981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goauthentik) | `90.15% <85.71%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=goauthentik#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

4d62 commented 1 week ago

@BeryJu hi. just looking thru my open issues / merge requests. should I add a test for this or is it fine the way it is? thanks