search

gobbledegook / creevey

Phoenix Slides
174 stars 25 forks source link

Regression: animated gif are not animated anymore #41

Closed huxi closed 5 months ago

huxi commented 5 months ago

Animated gif are not animated anymore in v1.5.6 on macOS 14.3.1.

Surprisingly, animated webp are now animated which wasn't the case until recently.

gobbledegook commented 5 months ago

I'm not able to reproduce this. Is this for all animated gifs, or just certain files?

gobbledegook commented 5 months ago

(animated webp was introduced as a feature in 1.5.4)

huxi commented 5 months ago

I think it's happening for all gifs.

I kind of assumed that this must be a me-problem in some way but I have no idea how.

I'm using an M2 MacBook Air (2023) and this used to work until recently.

This gif is animated in Quick Look but isn't in Phoenix Slides. For me.

Seinfeld

gobbledegook commented 5 months ago

well we have the same machine, system, and app versions, and jerry is waving his hands just fine for me... also the way gifs are animated is fundamentally unchanged since... whenever i introduced the feature, and it's similar to how webp's are animated...

do you have the same problem with this version?

https://blyt.net/phxslides/phoenix-slides-156d3.dmg

if so i can send you a version with some logging to try to see where it's failing...

huxi commented 5 months ago

Yes, same issue.

gobbledegook commented 5 months ago

Wait a minute... do you have "Show Large Images at Actual Size" turned on?

gobbledegook commented 5 months ago

ok assuming that was the case, try this version to see if it fixes the issue:

~blyt.net/phxslides/phoenix-slides-156d4.dmg~

huxi commented 5 months ago

Yes, that version works again!

gobbledegook commented 5 months ago

fixed in 1.5.7