search

gobblejs / gobble

The last build tool you'll ever need
333 stars 20 forks source link

pathwatcher → chokidar #106

Closed IvanSanchez closed 8 years ago

IvanSanchez commented 8 years ago

Replace the pathwatcher library with chokidar (https://github.com/paulmillr/chokidar).

This is due to gobble currently using 100% of my CPU when running (this happens since I upgrade out of node 0.12 to 4.4+, on linux).

MartinKolarik commented 8 years ago

Hmm... have you seen #92?

IvanSanchez commented 8 years ago

Ha, that's weird. In my case is totally the opposite, pathwatcher wastes CPU but chokidar just works.

The way I implemented it, any options to the source gobble node are passed to chokidar - maybe that way the user can set options to change behaviour in his/her system and prevent overheating the CPU?

IvanSanchez commented 8 years ago

@MartinKolarik Weird - upgrading the gobble dependency on pathwatcher to the latest version seems to fix my problem. Worth another PR, I guess.

IvanSanchez commented 8 years ago

Superseded by #107