search

gobblejs / gobble

The last build tool you'll ever need
333 stars 20 forks source link

fix build hang #56

Closed lukescott closed 9 years ago

lukescott commented 9 years ago

From what I could tell node.stop() was never called. I fixed that, and added some active() methods for a test I added to use to determine if node was still active or not.

Also had to rework the test/build.js to be similar to test/scenarios.js as there were some race conditions with the tests in that file.

Hopefully this hasn't broken anything else, but all the tests pass.

Related to gobblejs/gobble-cli/pull/11 and gobblejs/gobble-cli/issues/12.

Rich-Harris commented 9 years ago

This might also be fixed by the solution to https://github.com/gobblejs/gobble/issues/50, but since that's a 'might' and this is a 'does', in it goes! Thanks @lukescott

Rich-Harris commented 9 years ago

Released gobble 0.9.1 alongside 0.4.0. Should be good now

lukescott commented 9 years ago

Awesome, just updated my project and it works! 24 line build file (10 of it banner setting), so cool! Thanks guys.