gobench-io / gobench

A benchmark framework based on Golang
Apache License 2.0
73 stars 15 forks source link

Avoid using caret in versioning of Go and Node in CI Job #172

Closed duyndh closed 1 year ago

duyndh commented 1 year ago

I think we should not use caret when setting up the environment in CI to avoid compatible issues between deps.

Currently:

- name: Set up Go 1.16
  uses: actions/setup-go@v2
  with:
    go-version: ^1.16
  id: go

- name: Set up Nodejs 14
  uses: actions/setup-node@v2
  with:
    node-version: ^14.15
  id: node

CI will use Go 1.20.5 and Node 14.21.3

nguyencatpham commented 1 year ago

Go: should support the last 2 versions @hieult1393 will choose 1 Node version supported

hieult1393 commented 1 year ago

@duyndh @nguyencatpham I think we could use Node version 16.20.1

nguyencatpham commented 1 year ago

already resolve by #174 and #168