gobijan / nova-copilot-lsp

nova-copilot-lsp aims to provide integration with Github Copilot in Nova by Panic.
44 stars 5 forks source link

[BUG] Dosen't show device activation code #5

Open BenjaminHoegh opened 1 year ago

BenjaminHoegh commented 1 year ago

Is there an existing issue for this?

Current Behavior

Skærmbillede 2023-05-23 kl  19 00 01

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Relevant log output

No response

Anything else?

No response

devinbaeten commented 1 year ago

Also experiencing this in Nova 11.0

Westindies972 commented 1 year ago

Same issue for me in Nova 11

P-James commented 1 year ago

It doesn't display but it was in my clipboard. Just paste it in when the browser tab opens

Westindies972 commented 1 year ago

Thanks a lot, I just tried, it was in my clipboard.

halfnibble commented 1 year ago

OMG. So it was in my clipboard!

devinbaeten commented 1 year ago

It’s quite convenient that you put the code in our clipboard during the auth flow, but from a UX standpoint this is very bad.

Writing to the clipboard without a users knowledge could lead to loss of data and or (evidently) confusion.

Please consider making an alert that displays the code or a prompt asking to save the code to the clipboard.

gobijan commented 1 year ago

Feel free to open a PR an I'll review it :)

wptechnology commented 1 year ago

Yes same here... I have lost a lot of time to just finally found someone somewhere that says that it should be copied in the clipboard... Men, if you can't show an alert window, please write something in the extension console at least that says "Device code copied in clipboard... Just have to past it in the GitHub Page" !!!

gobijan commented 1 year ago

This was just a quick exploration to see if it was feasible. At the moment I do not plan on allocating time to this extension.

Feel free to create a PR with documentation fixes and the alert and log improvements. This shouldn't be too hard. Give it a try :)

TheBoatyMcBoatFace commented 11 months ago

Solution documented in https://github.com/gobijan/nova-copilot-lsp/pull/8

TheBoatyMcBoatFace commented 11 months ago

BenjaminHoegh

Have you tried it with the new docs? I hate to say _it worked for me, but when I ran through the nvim steps, things were groovy.

Here are the docs I'm taking about