search

gobitfly / eth2-beaconchain-explorer-app

Beaconchain Dashboard is an open source ethereum validator performance tracker app for Android and iOS.
https://beaconcha.in/mobile
GNU General Public License v3.0
243 stars 70 forks source link

Small Fixes Bundle #167

Closed manuelsc closed 1 year ago

D13ce commented 1 year ago

I have found a bug with the new income chart handling: image As you can see, the maximum of the charts y-axis is set to 0.132 yet the selected bar has a value of 0.155 i.e. it exceeds the maximum.

This is most likely caused by tickPositioner: function () { in dashboard.component.ts. Maybe the this.chart.series[X].dataMax handling has to be improved.

EDIT: Okay, I have quickly taken a look at that since it is my code anyways. I have committed a fix to this branch. Please take a look at it and simply close this conversation if everything looks good to you: 5e87dd55e75a52311065085bc29364008bacdb0d

D13ce commented 1 year ago

@manuelsc, as discussed, I have used this branch to fix yet another chart related bug (BIDS-1208). Please review commit 0fd983546eb94d8b60be4f6976227c8b45872b53 and close this conversation if everything's looking good.

manuelsc commented 1 year ago

lgtm