search

gobitfly / eth2-beaconchain-explorer-app

Beaconchain Dashboard is an open source ethereum validator performance tracker app for Android and iOS.
https://beaconcha.in/mobile
GNU General Public License v3.0
246 stars 73 forks source link

Proposal Luck includes pending validators in the calculation #221

Open p4fg opened 1 year ago

p4fg commented 1 year ago

Describe the bug The tab "Blocks" has a field "Proposal Luck" that includes non-activated/pending validators in the calculation of how many blocks is expected on average.

To Reproduce

  1. Create a new profile
  2. Add one active validator
  3. Add ten pending validators
  4. Visit the Blocks-tab and observe the proposal luck
  5. Click / press the questionmark and view the data saying "Your 11 validators are expected to produce XX blocks per month".

Expected behavior Only activated validators should be included in the calculation. Pending validators cannot produce any blocks.

manuelsc commented 1 year ago

Thanks for your bug report, I'm adding it to our todos

b0a7 commented 1 year ago

it also includes exited validators

Jircs1 commented 7 months ago

😁

jircs commented 6 months ago

👍

Motiff2 commented 1 month ago

👍