gobitfly / eth2-beaconchain-explorer-app

Beaconchain Dashboard is an open source ethereum validator performance tracker app for Android and iOS.
https://beaconcha.in/mobile
GNU General Public License v3.0
246 stars 73 forks source link

Fix max stake share for rockepool nodes with 8 ETH #272

Closed grozdanovgg closed 6 months ago

grozdanovgg commented 8 months ago

Since the Atlas Rocketpool upgrade was introduced, the validators can only provide 8 ETH to make a minipool instead of 16 ETH.

Here In the dashboard, it was assumed that if a validator is a Rocketpool one, its max share is always 16 ETH. So if a validator with 8 ETH tried to use the "Set Share" functionality, it ended up with the wrong share being calculated for him. For example - when setting the share to 6 ETH - the dashboard assumed that the validator's share is 37,5% instead of the correct value of 75%.

Akuta7 commented 5 months ago

That's good