Fixed an apparent operator precedence error

[PazerOP]

Fixed an apparent operator precedence error that caused all sorts of mayhem when windows tried to scroll their contents.

The previous code,

_absoluteX = echoConsole?.AbsoluteX ?? 0 + _x;
_absoluteY = echoConsole?.AbsoluteY ?? 0 + _y;

is functionally equivalent to

_absoluteX = echoConsole?.AbsoluteX ?? (0 + _x);
_absoluteY = echoConsole?.AbsoluteY ?? (0 + _y);

[goblinfactory]

much appreciated, reviewing now.

[goblinfactory]

I believe that has been fixed in latest alpha releases. I say "believe" because unfortunately I cannot run an acceptance test for "no longer causes massive mayhem!"

If you're ok doing a manual test on the latest alpha release, and give me the thumbs up that "no longer causes massive mayhem" then I'll cut a release of that and created an official non-alpha version 7.x release.

:)

I'll shuffle the release plans and move any breaking changes to version 8 and 9 respectively.

regards

Alan

[goblinfactory]

for your reference, here's the changes relating to setting absolute position in 7.x alpha that addresses that mayhem...

        private static (int absoluteX, int absoluteY) GetAbsolutePosition(IConsole parent, int x, int y)
        {
            int offset = 0; // hasTitle ? 1 : 0;
            var absoluteX = (parent?.AbsoluteX ?? 0) + x + offset;
            var absoluteY = (parent?.AbsoluteY ?? 0) + y + offset;
            return (absoluteX, absoluteY);
        }

I've also overhauled the main constructor, simplified it quite a bit in prep for the big changes in 8 and 9, to support proper text editing controls, and pave the way for a proper cross platform HighspeedWriter.

[goblinfactory]

If you would prefer a last final patch to end of version 6.2.1, rather than me releasing a final 7.x let me know. While Konsole has a lot of downloads and users, I don't get a huge amount of interaction with users so have focused on pushing towards releasing full text editing features, a critical aspect necessary to make it into a serious "essential" development tool. My strategy has been to put effort into forward changes, not backward patches. No point in investing in support users that may not be using or benefitting from any effort. I could be fixing bugs that no one is impacted by... that effort can go towards a more stable newer release. That being said, i will always do my best to support existing users that are pushing the limits of what Konsole can do, because that collaboration is always the most valuable; so please tell me what works best for you? cheers, Alan

[PazerOP]

I'm not sure what your release strategy is, this patch was just to fix an issue that I observed on master after downloading the package from nuget. I generally avoid using alpha/beta releases when I just want to get something done, especially if its an alpha from months ago.

[goblinfactory]

The bug was uncovered much later after I had already started quite a bit of refactoring in version 7. I'm only using alpha/beta releases because the work I'm doing involves a lot of changes to the API, and I dont want to have to up the version number every time I make a small or big change to the API. I've done a reasonable bit of work on the alphas and am using them now with a financial client with several fixes and improvements.

Another reason I'm using alphas is that the changes are significant, not cosmetic and will require that I totally rewrite the documentation. For example, the theming, allowing client windows to inherit style theme from parent windows is a large change that requires a rework of much of the API. Any documentation will have to be done before I can release a new verison.

I realise that i can't do that quickly (the documentation), so it makes sense for me to simply patch current master.

I'll Merge your PR, check the tests, and create a new release tomorrow.

txs again! Cheers, Alan

[goblinfactory]

Hi @PazerOP I've released hotfix nuget package 6.2.2 txs again for the PR. regards, Alan