Switch from `BatEnum` to `Seq` - Githubissues

goblint / analyzer

Static analysis framework for C

https://goblint.in.tum.de

MIT License

172 stars 72 forks source link

Switch from `BatEnum` to `Seq` #1443

Open karoliineh opened 5 months ago

karoliineh commented 5 months ago

A try on switching to the more standard Seq.t in Enum instances where possible as proposed in #1437

Some things that I noticed:

Enum.cartesian_product is called product in Seq
Enum.uncombine is called unzip (or split) in Seq
Enum.fold is called fold_left in Seq
There is no corresponding function to Enum.uniq in Seq
There is no to_seq in BatHashtbl
There is no to_seq_keys in BatHashtbl as in the Ocaml standard library Hashtbl

TODO

[ ] Fix Gobview.
[ ] Wait for https://github.com/ocaml-batteries-team/batteries-included/pull/1133 to release?
[x] Bump OCaml lower bound to 4.14? Many Seq functions are that new. (#1448)