goblint / analyzer

Static analysis framework for C
https://goblint.in.tum.de
MIT License
160 stars 72 forks source link

Fix Apron `compare` function usage #1506

Open sim642 opened 3 weeks ago

sim642 commented 3 weeks ago

https://github.com/antoinemine/apron/issues/99 is mitigated by https://github.com/antoinemine/apron/pull/108, which should be released as Apron v0.9.15 soon.

This PR aims to fix compatibility with this breaking change. It would be possible for us to implement a proper GobApron.Environment.compare, but I don't know if we really need it. I'm more worried about our comparison of Apron.Abstract1.t-s via Stdlib.compare, which won't work now. It doesn't seem to break our tests, but it might still be possible in some case we end up needing to call such comparison and crashing (which will explicitly break instead of being implicitly wrong sometimes).