goblint / analyzer

Static analysis framework for C
https://goblint.in.tum.de
MIT License
160 stars 72 forks source link

Relational analysis always populates result table even when not dumping #1526

Closed michael-schwarz closed 4 days ago

michael-schwarz commented 1 week ago

https://github.com/goblint/analyzer/blob/9402f1c00fc7a92e8e9ce3cad3cd4076a710987d/src/analyses/apron/relationAnalysis.apron.ml#L757-L776

Here, the table results is always populated, even whenexp.relation.prec-dump is off, and results is never considered. This is likely not terribly expensive given casting to octagons only happens later, but still completely unnecessary.