search

gobolinux / Compile

The GoboLinux build tool
52 stars 15 forks source link

NewVersion has problems dealing with Recipe files including multibyte character #13

Closed AitorATuin closed 7 years ago

AitorATuin commented 7 years ago

I have found that some recipes contain multibyte characters and NewVersion is complaining and failing to generate a new version of the Recipe.

❯ NewVersion Wireshark 2.2.3 https://1.na.dl.wireshark.org/src/wireshark-2.2.3.tar.bz2
NewVersion: Locating a recipe for Wireshark...
NewVersion: Found recipe for Wireshark at /Data/Compile/LocalRecipes/Wireshark/2.2.0
GetRecipe: Trying to get /Data/Compile/LocalRecipes/Wireshark/2.2.0
NewVersion: Recipe placed in /Data/Compile/LocalRecipes/Wireshark/2.2.0
NewVersion: Creating recipe for Wireshark 2.2.3 based on 2.2.0.
Recipe: línea 2: Coincidencia: no se encontró la orden
Recipe: línea 2: Coincidencia: no se encontró la orden
NewVersion: Downloading source code...
/Data/Compile/LocalRecipes/Wireshark/2.2.3/Recipe: línea 2: Coincidencia: no se encontró la orden
lucasvr commented 7 years ago

NewVersion is quite hackish and has a set of known issues (see #11, for instance.) I'd say that the best approach would be to rewrite it on e.g., Python.

AitorATuin commented 7 years ago

Agreed. Anyway the fix is straightforward so i will send a PR to fix it.

AitorATuin commented 7 years ago

PR fixing it: https://github.com/gobolinux/Compile/pull/14

AitorATuin commented 7 years ago

btw maybe is time to give it a chance to lua :)

lucasvr commented 7 years ago

I wouldn't mind at all to have it rewritten in Lua. PRs are welcome :)