gobolinux / Compile

The GoboLinux build tool
52 stars 15 forks source link

`docs=()` directive does not work #54

Closed Nuc1eoN closed 2 years ago

Nuc1eoN commented 2 years ago

The docs docs=() directive does not appear to do anything at all, unless I am mistaken. It seems to be broken.

See package GLM.

hishamhm commented 2 years ago

See package GLM.

I think it works, but it don't think it supports wildcards.

Implementation in Functions/Compile looks like this:

for i in COPYING LICENSE README* NEWS AUTHORS BUGS TODO COPYRIGHT ${docs:+"${docs[@]}"}
Nuc1eoN commented 2 years ago

Yes you are right, I corrected it in the GLM recipe https://github.com/gobolinux/Recipes/commit/3e937017a4cba69b018c54567d68f9714e54f0f2#diff-6f368c07c35092c010bf62ab020949084ec7604591d21cd9d4acb7dd44b4b360

I might open a feature request, since wildcards would be very useful. Actually I have seem quite some recipes that defined wildcards for docs=, so those are probably "broken".