search

gobolinux / Recipes

The GoboLinux recipes repository
107 stars 30 forks source link

Neofetch GIT obsolete patch removal #211

Closed sage-etcher closed 5 months ago

sage-etcher commented 5 months ago

Removed the 0001-Update-gobolinux-art.patch file. Said patch attempts to act on the ascii/distro/gobolinux file, modifying the ASCII art for the distribution.

Following a restructuring of the Neofetch codebase, the ascii/distro/gobolinux file no longer exists; All ascii/distro/* artworks are now contained within the main executable, neofetch. Further, as of writing this, the artwork for GoboLinux no longer requires patching, as it is correct by default.

Without the removal of this patch, the Compile script fails, as it cannot find the (deleted) ascii/distro/gobolinux file.

Nuc1eoN commented 5 months ago

Oh makes total sense actually, to leave out the patch on the git version :thinking: . That would certainly lead to breakages more often than not. I wasn't even aware that neofetch has a Gobo artwork natively by now tbh.

Gotta check that out. Maybe we can even add it to the default terminal setup in a future Gobolinux release if it's nice (Gobo default settings are provided by https://github.com/gobolinux/EnhancedSkel btw).

GoboLinux 017.01 ISO will focus on bug fixes though. The current user experience for newcomers is atrocious (CA-Certificates, kernel too outdated for modern hw etc).