ZLib 1.3.1

[sage-etcher]

• NewVersioned to 1.3.1
• Compile, succeeded
• make test in build dir, succeeded
• updated file name in i386.Darwin/Recipe to use version 1.3.1
• recreated i386.FreeBSD/01-freebsd-z_off_t.patch file for version 1.3.1

Note: I did NOT test Darwin or FreeBSD. Both were carried over from the prior version, use at your own discretion!

[Nuc1eoN]

Seems you are getting the hang of NewVersion (it's fun.. mostly! :grin:)

Note: I did NOT test Darwin or FreeBSD. Both were carried over from the prior version, use at your own discretion!

Hmmm frankly, I have not the slightest idea why that is even there, or if that is still relevant for us today. It seems to have been added in Zlib v1.2.3 by @detsch, in year 2005! Had not been there in recipe v1.2.2. The oldest git history dates back to 2008 sadly.

Maybe Gobolinux attempted to support FreeBSD/MacOS back then? I am like 99% sure this is irrelevant for us nowadays.

@detsch kindly, if you are still around I'd be grateful for some background why this is included in the recipe.

I am gonna leave this PR open for a while to give the opportunity to comment.

[detsch]

Maybe Gobolinux attempted to support FreeBSD/MacOS back then? I am like 99% sure this is irrelevant for us nowadays.

Hi there! I can't remember using BSD patch or the Darwin Recipe myself.

The BSD patch was probably part of this experimental effort: https://github.com/gobolinux/GoboBSD

I don't see an issue dropping it. Perhaps @lucasvr has a more informed opinion, specially about the Darwin part.

[Nuc1eoN]

Thank you @detsch for your assessment! :+1:

So 99,9% these are safe to drop. The GoboBSD repo hasn't been updated in 16 years -- no need to keep unused, untested functionality around imho..

@sage-etcher Please remove the BSD and Darwin specific files and I will merge this. Should @lucasvr raise any remarks we can always add it later :)

[Nuc1eoN]

Hi, thank you for the changes. I have also updated the Description file since it has been super outdated. Merging.