gobrightspot / nova-detached-actions

A Laravel Nova tool to allow for placing actions in the Nova toolbar detached from the checkbox selection mechanism.
MIT License
168 stars 50 forks source link

Laravel Nova 4.0 Support #69

Open h888t opened 2 years ago

h888t commented 2 years ago
  Problem 1
    - gobrightspot/nova-detached-actions is locked to version 1.1.1 and an update of this package was not requested.
    - gobrightspot/nova-detached-actions 1.1.1 requires laravel/nova ^3.0 -> found laravel/nova[dev-master, v3.0.0, ..., 3.x-dev (alias of dev-master)] but it conflicts with your root composer.json require (~4.0).

when updating to Laravel Nova v4.

ibrahem-kamal commented 2 years ago

i dont think its gonna be updated as nova 4 has already this feature implemented

link for documentation

centgart commented 2 years ago

@ibrahem-kamal trouble is that Nova 4 still shows standalone action within the action dropdown, and the good thing this package adds is an ability to make separate action button next to Create Resource button. Less clicks for heavily used actions, better UI.

RenoLooijmans commented 2 years ago

Bump. Would like to have this package work for Nova 4 as well.

vesper8 commented 2 years ago

This fork has Nova 4 support

https://github.com/lucidlogic/nova-detached-actions

@lucidlogic Any chance you could take all of your awesome changes in your fork and submit a PR?

RenoLooijmans commented 2 years ago

This fork has Nova 4 support

https://github.com/lucidlogic/nova-detached-actions

@lucidlogic Any chance you could take all of your awesome changes in your fork and submit a PR?

Are you sure his fork works for Nova 4? I have tried it but I couldn't get it to work...

georgep-am commented 2 years ago

I have also tried to install the fork but couldn't get it to work. Is there anything I may be missing?

Hemnyos commented 2 years ago

yea, the "composer require gobrightspot/nova-detached-actions" doesnt work at all 😅

ali-raza-saleem commented 2 years ago

I have created PR for Nova 4 Update. Tested all the features. Working as expected. https://github.com/gobrightspot/nova-detached-actions/pull/74

matthewhutchings commented 2 years ago

Please review PR above.

adrianmihaila commented 2 years ago

I have created PR for Nova 4 Update. Tested all the features. Working as expected. #74

Hi @the-alichemist. I saw that your PR was merged. Can you please create a tag for this new version? Thanks a lot.

adrianmihaila commented 2 years ago

Also, I found an issue. If I disable the standalone property from a detached action, and I show that action onlyOnIndexToolbar when you select one or two resources for example from the listing and click on the detached action button, on:

public function handle(ActionFields $fields, Collection $resources) {}

you will get all resources. Like you pressed on the select all checkbox. Is there anyone that noticed this issue?

adrianmihaila commented 2 years ago

I created a PR for the issue: https://github.com/gobrightspot/nova-detached-actions/pull/75

jjjrmy commented 1 year ago

Is there any way to put the button next to the others?

Screen Shot 2022-11-13 at 4 21 04 PM
mrleblanc101 commented 1 year ago

Since #75 has been merged, what are we waiting for to create a new release ?

vesper8 commented 1 year ago

75 doesn't look merged to me...

mrleblanc101 commented 1 year ago

@vesper8 I meant #74, which include Nova 4 support

vesper8 commented 1 year ago

Ah right.. well I agree with you, a new tag would be nice. I've just been using "gobrightspot/nova-detached-actions": "dev-master", for a while now and it does work great.

d00p commented 1 year ago

@jjjrmy i got the same issue...rest seems to work just fine

wajeht commented 1 year ago

Is there any way to put the button next to the others? Screen Shot 2022-11-13 at 4 21 04 PM

@jjjrmy i got the same issue...rest seems to work just fine

same here, did you guys figured out?