Open h888t opened 2 years ago
i dont think its gonna be updated as nova 4 has already this feature implemented
@ibrahem-kamal trouble is that Nova 4 still shows standalone action within the action dropdown, and the good thing this package adds is an ability to make separate action button next to Create Resource button. Less clicks for heavily used actions, better UI.
Bump. Would like to have this package work for Nova 4 as well.
This fork has Nova 4 support
https://github.com/lucidlogic/nova-detached-actions
@lucidlogic Any chance you could take all of your awesome changes in your fork and submit a PR?
This fork has Nova 4 support
https://github.com/lucidlogic/nova-detached-actions
@lucidlogic Any chance you could take all of your awesome changes in your fork and submit a PR?
Are you sure his fork works for Nova 4? I have tried it but I couldn't get it to work...
I have also tried to install the fork but couldn't get it to work. Is there anything I may be missing?
yea, the "composer require gobrightspot/nova-detached-actions" doesnt work at all 😅
I have created PR for Nova 4 Update. Tested all the features. Working as expected. https://github.com/gobrightspot/nova-detached-actions/pull/74
Please review PR above.
I have created PR for Nova 4 Update. Tested all the features. Working as expected. #74
Hi @the-alichemist. I saw that your PR was merged. Can you please create a tag for this new version? Thanks a lot.
Also, I found an issue. If I disable the standalone
property from a detached action, and I show that action onlyOnIndexToolbar
when you select one or two resources for example from the listing and click on the detached action button, on:
public function handle(ActionFields $fields, Collection $resources) {}
you will get all resources. Like you pressed on the select all checkbox. Is there anyone that noticed this issue?
I created a PR for the issue: https://github.com/gobrightspot/nova-detached-actions/pull/75
Is there any way to put the button next to the others?
Since #75 has been merged, what are we waiting for to create a new release ?
@vesper8 I meant #74, which include Nova 4 support
Ah right.. well I agree with you, a new tag would be nice. I've just been using "gobrightspot/nova-detached-actions": "dev-master",
for a while now and it does work great.
@jjjrmy i got the same issue...rest seems to work just fine
Is there any way to put the button next to the others?
@jjjrmy i got the same issue...rest seems to work just fine
same here, did you guys figured out?
when updating to Laravel Nova v4.