search

gobuffalo / buffalo

Rapid Web Development w/ Go
http://gobuffalo.io
MIT License
8.07k stars 573 forks source link

Extend `worker.Worker` to support periodic job registration #2308

Closed acaloiaro closed 1 year ago

acaloiaro commented 2 years ago

Extend worker.Worker to support periodic job registration, in support of https://github.com/gobuffalo/gocraft-work-adapter/issues/6

The purpose of this PR is to invite commentary on adding periodic job support. A concrete worker.Simple implementation would follow, along with tests.

sio4 commented 2 years ago

Please change the merge target to v1. The main branch is not yet ready.

sio4 commented 2 years ago

Hi @acaloiaro, sorry for my late response.

It seems like you worked based on the main branch, which is not yet prepared. (I am working on setting the next version's tree on there, but not yet finished) Please rebase your fix on the v1 branch. Also, it could be better if you run the basic test on your local env before pushing the change.

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days.

acaloiaro commented 1 year ago

@sio4

I went ahead and rebased, and provided a concrete Simple implementation using github.com/robfig/cron as the cron implementation. This is the same dependency underlying https://github.com/gocraft/work and consequentially https://github.com/gobuffalo/gocraft-work-adapter

acaloiaro commented 1 year ago

Closing for now while a more holistic design is considered in #2242