gobuffalo / buffalo

Rapid Web Development w/ Go
http://gobuffalo.io
MIT License
8.07k stars 573 forks source link

removed pop logger setting that is not required to do by buffalo #2346

Closed sio4 closed 1 year ago

sio4 commented 1 year ago

We don't need to configure a pop logger here. By default, the logger used for the app generated by buffalo will use the following logger if they are configured with pop middleware. This is redundant and it made the buffalo core depends on pop.

https://github.com/gobuffalo/buffalo-pop/blob/e56c88988c60c8567cb7da927354c7d734665b20/pop/popmw/tx.go#L29

Now, we completely decoupled buffalo and pop.