gobuffalo / buffalo

Rapid Web Development w/ Go
http://gobuffalo.io
MIT License
8.07k stars 573 forks source link

feature: Move MIME support out of internal #2357

Closed jason-jackson closed 1 year ago

jason-jackson commented 1 year ago

Description

Currently MIME support is through mail/internal/mail/message.go, an internal package. So if I wanted to create my own Sender/BatchSender implementation with MIME support, I would need to duplicate code. Options I see:

Thanks!

Additional Information

No response

jason-jackson commented 1 year ago

I'm completely fine with exposing it as a writer instead of []byte, just would be nice to have available without having to copy/paste from smtp. Had []byte as working with ses, which takes in a byte slice.

sio4 commented 1 year ago

I did not take a look into your issue in detail, but just want to tell you the following things around the package:

with this context, I can tell we will not expose anything from the internal mail package but we may be able to expand Buffalo's mail package. If your issue is about extending Buffalo's mail, please explain more about the purpose, use case, direction, or anything you think. However, if your issue is something directly related to the internal mail package, I think checking the modules above or the other modules for MIME support could be better.

sio4 commented 1 year ago

I am closing it for now, but please feel free to reopen it if you think my answer does not help you and we need more discussion on this topic.