gobuffalo / buffalo

Rapid Web Development w/ Go
http://gobuffalo.io
MIT License
8.07k stars 573 forks source link

bug: Generated new app with vcs=none sets the directory is registered as a Git root. #2387

Closed paxer closed 9 months ago

paxer commented 10 months ago

Description

Description

I generated the new app with these parameters while inside the existing repository. The idea was to add the buffalo app as yet another app to Go's workplace.

buffalo new buffalo_app --api --vcs=none --skip-docker --ci-provider=github

I noticed something strange, while the git repo was not created for the buffalo_app, I got a Git error:

Invalid VCS root mapping The directory is registered as a Git root, but no Git repositories were found there.

As a workaround, I created the app in another place (not inside the existing git repo) and copied the generated folder to my original git repository.

Expected Behavior

The newly generated app inside of the other git repository with --vcs=none does not set the directory registered as a Git root.

Actual Behavior

The newly generated app inside of the other git repository with --vcs=none set the directory registered as a Git root.

To Reproduce

generate a new app with

buffalo new buffalo_app --api --vcs=none --skip-docker --ci-provider=github

while inside of the another git repository

Additional Context

Details

``` Paste the output of `buffalo info` here! ```
github-actions[bot] commented 9 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days.

github-actions[bot] commented 9 months ago

This issue was closed because it has been stalled for 30+7 days with no activity.