search

gobuffalo / buffalo

Rapid Web Development w/ Go
http://gobuffalo.io
MIT License
8.07k stars 573 forks source link

feature: Support the upload of multiple files #2389

Open karlhaas opened 9 months ago

karlhaas commented 9 months ago

What is being done in this PR?

Supports slices of files in multipart form requests. Fixes https://github.com/gobuffalo/buffalo/issues/1770

What are the main choices made to get to this solution?

The solution was already suggested here: https://github.com/gobuffalo/buffalo/issues/1770#issuecomment-821284875

List the manual test cases you've covered before sending this PR:

In our project we upload several files using the same multi part name "files".

karlhaas commented 9 months ago

@markbates could you please review and merge? The last time it got closed because nobody cares ...

dammy001 commented 9 months ago

@markbates could you please review and merge? The last time it got closed because nobody cares ...

any update with this PR? When should we expect this to get reviewed?

paganotoni commented 9 months ago

@karlhaas @dammy001 I'm not @markbates, but I can look if you want. It looks good to me so far.

paganotoni commented 9 months ago

@karlhaas, some tests are broken. Can you take a look and LMK when those are passing?

karlhaas commented 9 months ago

@paganotoni i removed the check of the file size. Please check thx.

karlhaas commented 9 months ago

@paganotoni could you please merge and release?

github-actions[bot] commented 7 months ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days.

karlhaas commented 7 months ago

@paganotoni who will merge it?