search

gobuffalo / buffalo

Rapid Web Development w/ Go
http://gobuffalo.io
MIT License
8.09k stars 575 forks source link

generate a default .travis.yml file for new projects #36

Closed markbates closed 7 years ago

briandowns commented 7 years ago

Should there be a flag similar to --db-type for CI provider? e.g. --ci-provider and support Travis and Circle out of the box? Maybe add others depending on demand?

markbates commented 7 years ago

That seems like a good idea.

briandowns commented 7 years ago

I have a branch started to complete the default travis file but if the additional flag is an acceptable approach, I'd like to include that as well. Also, was hoping for feedback on implementation: cobra command to generate the buffalo g flags mentioned above.

markbates commented 7 years ago

If there's only CI we don't need a flag, for now. When we want different CI files, then we can add a flag.

There are plenty of examples of how to use flags in the cmd directory.

briandowns commented 7 years ago

I can add that flag functionality for different CI providers in this branch if you want. Your call. :)

markbates commented 7 years ago

I'd love it if you feel comfortable enough generating files for other CIs!

briandowns commented 7 years ago

Cool. I'll add the travis functionality as well as Circle to start. I'm open to others.

markbates commented 7 years ago

Those two would be great! Wercker would be awesome as well, if you can get to it.

paganotoni commented 7 years ago

@briandowns are you working on this one ? i have some time to give it a shot, but if you're working on it prefer you to complete it :)

cdrx commented 7 years ago

Is there an example of a working circle.yml or travis-ci.yml file?

briandowns commented 7 years ago

I'll try to get this pushed up today.

On Jan 17, 2017, at 04:38, Chris R notifications@github.com wrote:

Is there an example of a working circle.yml or travis-ci.yml file?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

stanislas-m commented 7 years ago

Gitlab CI support could be cool too. :)

markbates commented 7 years ago

A wercker set up would be great too. These should be separate tickets though.

paganotoni commented 7 years ago

@markbates i started working on the .travis.yml generation, however when running the tests for the first time its panic'ing with:

--- FAIL: Test_HomeHandler (0.00s)
panic: could not locate box "../public/assets" [recovered]
    panic: could not locate box "../public/assets"

Should we remove the .gitignore from public/assets folder or handle rice diferently when running tests ? Also for the travis configuration, i'm assuming we should run migrations/setup database and run the tests with buffalo test, am i right ?

paganotoni commented 7 years ago

@markbates nevermind, i ended up creating the folder on the .travis.yml