gobuffalo / cli

The Buffalo CLI
19 stars 24 forks source link

fixed broken behavior of buffalo test -m #181

Closed sio4 closed 2 years ago

sio4 commented 2 years ago

Not sure when the issue started, but buffalo test -m TEST was not working as expected. The bug was reported as #180 recently (transferred from the buffalo repository).

This fix fixes the following things:

fixes #180

paganotoni commented 2 years ago

This -m flag is something I've been thinking about while working on the new CLI architecture. I've been thinking if this is something standard in Go or something that Testify requires and how do we write our CLI so we are not dependent on Testify.

sio4 commented 2 years ago

This -m flag is something I've been thinking about while working on the new CLI architecture. I've been thinking if this is something standard in Go or something that Testify requires and how do we write our CLI so we are not dependent on Testify.

In our code, the -m works as two ways.

So what I found for -m is a kind of meta flag to be transformed into the standard -run or testify style and I think this method is useful. (Actually, the scaffolded app supports testify)

paganotoni commented 2 years ago

Was taking the time to review how this impacted the v1 version of all this. Thanks for adding the comments @sio4.