search

gobuffalo / genny

A framework for writing modular generators
MIT License
65 stars 14 forks source link

Add other common types for attr #5

Closed paganotoni closed 5 years ago

paganotoni commented 6 years ago

We may need to add other common types mapping in here:

https://github.com/gobuffalo/genny/blob/9033ae798a5a8575a9a9f95bd3f0a2c16f8fa3c1/movinglater/attrs/attrs.go#L16

In order to be able to support Pop

markbates commented 6 years ago

Yes! That method is incomplete. Not even close to ready. :)

Thanks.

Mark Bates On Sep 29, 2018, 1:44 PM -0400, Antonio Pagano notifications@github.com, wrote:

We may need to add other common types mapping in here: https://github.com/gobuffalo/genny/blob/9033ae798a5a8575a9a9f95bd3f0a2c16f8fa3c1/movinglater/attrs/attrs.go#L16 In order to be able to support Pop — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

paganotoni commented 6 years ago

@markbates added types in #8