gobuffalo / genny

A framework for writing modular generators
MIT License
65 stars 14 forks source link

Hey @fasmat, #54

Closed LolyPopToyou closed 1 year ago

LolyPopToyou commented 1 year ago
          Hey @fasmat,

I just figured out that current runners doesn't support fs.FS, so this issue would be a great enhancement.

What I have in mind is a single NewRunner(fs.FS) :

That said DryRunner and WetRunner could be kept, but they will just call NewRunner with the appropriate fs.

What do you think ?

EDIT: seems like I went a little too fast, fs.FS is only a readable interface, so it cannot be used by a runner. Maybe this will change in the future.

Originally posted by @tbruyelle in https://github.com/gobuffalo/genny/issues/43#issuecomment-1372213050

sio4 commented 1 year ago

seems like mistakenly created.