gobuffalo / middleware

The default middleware for Buffalo apps
MIT License
1 stars 4 forks source link

process: consolidate the default middlewares into a single module #1

Closed sio4 closed 1 year ago

sio4 commented 1 year ago

As of today, we have 7 official middleware modules and 4 of them are used in a new app by default. Now, these middleware are stable and have no much update recently except dependency updates. To reduce the maintenance effort on these modules, and also to simplify the module dependency structure, I would like to consolidate the default middleware (which are mw-csrf, mw-forcessl, mw-i18n, and mw-paramlogger) into a single module. Each of them will be a separate package in the module but will share the same module version and other stuff.

The process will be:

Hey @paganotoni, as we discussed before, I am going to deprecate the old default middleware modules (4 modules) and merge them into this module. Please take a look at the rough process above and let me know if you have any concern or comment on it. ETA for this work is the end of this month roughly.

Related tasks:

paganotoni commented 1 year ago

I'm glad you brought this one up, and I appreciate what you're doing here. This will make our codebase way simpler.

sio4 commented 1 year ago

Completed!