search

gobuffalo / plush

The powerful template system that Go needs
MIT License
895 stars 57 forks source link

catch out of bounds slice/array index access #145

Closed Mido-sys closed 2 years ago

Mido-sys commented 3 years ago

An error will return to the user if they try to access an index that doesn't exist.

Example: array index out of bounds, got index 5, while array size is 5

Mido-sys commented 2 years ago

@paganotoni Just a friendly reminder :)

paganotoni commented 2 years ago

Thanks for the reminder @Mido-sys. I left a couple of minor things to tweak. this is looking good.

Mido-sys commented 2 years ago

@paganotoni sounds good. Thank you.

Mido-sys commented 2 years ago

@paganotoni, Sorry, I misread your comment. Did you mean that you left some notes for me to improve?

paganotoni commented 2 years ago

Yes just a few small things.

Mido-sys commented 2 years ago

@paganotoni, where did you leave your comments? I can't find it.

paganotoni commented 2 years ago

@Mido-sys I had that review in pending status. now sent. Thanks for asking.