search

gobuffalo / plush

The powerful template system that Go needs
MIT License
895 stars 57 forks source link

Fix if condition if one of the nodes is undefined while the operator is Or and the other node is true #164

Closed Mido-sys closed 1 year ago

Mido-sys commented 1 year ago

Fix for issue #157

Mido-sys commented 1 year ago

@sio4, just a kind reminder :)

sio4 commented 1 year ago

@sio4, just a kind reminder :)

Sorry for that. I couldn't make a time today. Will check as soon as possible!

Mido-sys commented 1 year ago

@sio4, no worries!! Thanks, the Timezone difference makes it hard :)

sio4 commented 1 year ago

Hi @Mido-sys,

FYI, I found some issues (side effects) on this PR while I review the method to improve the efficiency, and filed a PR (#166) to fix the issue. The main difference between those two approaches is that yours is more focused on the value, but mine is focused on the operations.

Just wanted to let you know about the change!