gobuffalo / plush

The powerful template system that Go needs
MIT License
895 stars 57 forks source link

fixed #164's bug by focusing on the operator instead of the value #166

Closed sio4 closed 1 year ago

sio4 commented 1 year ago

I found that #164's approach is problematic because the fix is focused on the value and it modifies the value itself (from nil to false when if the error is kind of "unknown identifier"). However, since the method is not only for logical operations, the fix made side effects on the evaluation of arithmetic operators and handling nil itself.

This PR has two commits:

fixes #157 fixes #165