gobwas / glob

Go glob
MIT License
948 stars 63 forks source link

Benchmarks should be done with DOTALL #21

Open sylvinus opened 7 years ago

sylvinus commented 7 years ago

In the benchmark against the regexp package, the DOTALL regexp option should be used because without it .* is not the same as the glob * (regexp has to exclude \n). A \n separator for glob could also be used.

I suspect doing that will narrow the gap between glob and regexp but provide a fairer comparison.

Thanks!