General Updates - Githubissues

gobwas / gulp-sprite-generator

Plugin that generate sprites from your stylesheets.

42 stars 16 forks source link

General Updates #13

Closed brianreavis closed 8 years ago

brianreavis commented 8 years ago

Official support for Node 4/5
Better error handling (there were a few places where errors weren't being handled, which caused gulp to silently stop without any info)
Updated spritesmith 0.18.0 -> 3.1.0
Updated lodash 2.4.1 -> 4.1.1
Updated through2 0.4.1 -> 2.0.1
Updated async 0.2.10 -> 2.0.0-rc.3
Updated vinyl 0.2.3 -> 1.1.1
Dropped Q in favor of es6-promise (easier to drop later when promises are mainstream)

p.s. sorry in advance for style changes

brianreavis commented 8 years ago

Going to stop you there – this isn't going to be worth either of our time.

gobwas commented 8 years ago

Thanks for your work and PR, but I did not understand the sense of changing the coding style without meaningful reason. If you want, you could refactor the logic as you did with filtering images and it's ok and welcome. Also Im agree with the one lined var. But another code style changes did not makes sense for me.